Configure ginkgo to use the `KUBE_BASTION_SSH` env variable #16008

upodroid · 2023-10-08T16:37:18Z

I need to fix a bug in kubetest2 to make this work. kubernetes-sigs/kubetest2#247

k8s-ci-robot · 2023-10-08T16:37:23Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign olemarkus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

upodroid · 2023-10-10T00:05:37Z

/test pull-kops-kubernetes-e2e-cos-gce-serial

johngmyers · 2023-10-10T04:50:07Z

upup/pkg/fi/cloudup/gce/instancegroups.go

+		cm.Roles = append(cm.Roles, "control-plane")
+		cm.PrivateIP = fi.ValueOf(&instance.NetworkInterfaces[0].NetworkIP)
+		cm.ExternalIP = fi.ValueOf(&instance.NetworkInterfaces[0].AccessConfigs[0].NatIP)
+	}


Why does this avoid setting the PrivateIP and ExternalIP when there is no role label? Why not unconditionally set those regardless of the role label?

It doesn't, look at 282 to 284.

johngmyers · 2023-10-10T04:54:44Z

tests/e2e/pkg/tester/tester.go

+		for _, instance := range instances {
+			for _, role := range instance.Roles {
+				if role == "control-plane" && instance.ExternalIP != "" {
+					t.Env = append(t.Env, fmt.Sprintf("KUBE_SSH_BASTION=%s", instance.ExternalIP))


For a three-node control plane we would set KUBE_SSH_BASTION three times?

Forgot about that, we need just one IP.

hakman · 2023-10-10T07:16:25Z

This is more or less a hack (as you also said it in Slack). It is probably the easy way to do it, but not quite sure it's the right thing to do.
Why can't something be done in k/k to list the control-plane IPs and choose one of them? I think I've seen in the past some tests that do that.

@aojea Any thoughts?

upodroid · 2023-10-10T10:21:55Z

/test pull-kops-kubernetes-e2e-cos-gce-serial

k8s-ci-robot · 2023-10-12T09:36:45Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2024-01-18T04:23:07Z

@upodroid: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kops-e2e-k8s-gce-cilium	`a4f364e`	link	true	`/test pull-kops-e2e-k8s-gce-cilium`
pull-kops-e2e-k8s-gce-ipalias	`a4f364e`	link	true	`/test pull-kops-e2e-k8s-gce-ipalias`
pull-kops-kubernetes-e2e-cos-gce-serial	`a4f364e`	link	false	`/test pull-kops-kubernetes-e2e-cos-gce-serial`
pull-kops-kubernetes-e2e-ubuntu-gce-build	`a4f364e`	link	true	`/test pull-kops-kubernetes-e2e-ubuntu-gce-build`
pull-kops-verify-hashes	`a4f364e`	link	true	`/test pull-kops-verify-hashes`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-triage-robot · 2024-04-17T05:14:56Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-05-17T05:36:20Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-06-16T05:51:47Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-06-16T05:51:52Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 8, 2023

k8s-ci-robot requested review from hakman and zetaab October 8, 2023 16:37

k8s-ci-robot added area/provider/gcp Issues or PRs related to gcp provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 8, 2023

upodroid changed the title ~~Configure ginkgo to use the IP of the Controlplane directly for e2e testing~~ Configure ginkgo to use the KUBE_BASTION_SSH env variable Oct 8, 2023

upodroid force-pushed the amend-how-ginkgo-infers-ssh branch from d1f888f to 178ba34 Compare October 8, 2023 18:34

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 9, 2023

upodroid force-pushed the amend-how-ginkgo-infers-ssh branch from e0e40e7 to 6f5258b Compare October 9, 2023 23:34

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 9, 2023

upodroid force-pushed the amend-how-ginkgo-infers-ssh branch from 6f5258b to 3658b11 Compare October 9, 2023 23:43

upodroid mentioned this pull request Oct 10, 2023

kube-up to kops replacement blockers #15983

Open

johngmyers reviewed Oct 10, 2023

View reviewed changes

configure KUBE_SSH_BASTION for gce tests and bump deps

a4f364e

upodroid force-pushed the amend-how-ginkgo-infers-ssh branch from 3658b11 to a4f364e Compare October 10, 2023 09:39

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2023

upodroid mentioned this pull request Nov 11, 2023

fix the gce info shown in kops get cmd and set node-tag ginkgo flag #16096

Merged

upodroid mentioned this pull request Nov 27, 2023

Enable containerd test-handler runtimeclass for k/k e2e tests #16056

Merged

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 17, 2024

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 17, 2024

k8s-ci-robot added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label May 17, 2024

k8s-ci-robot closed this Jun 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configure ginkgo to use the `KUBE_BASTION_SSH` env variable #16008

Configure ginkgo to use the `KUBE_BASTION_SSH` env variable #16008

upodroid commented Oct 8, 2023 •

edited

Loading

k8s-ci-robot commented Oct 8, 2023

upodroid commented Oct 10, 2023

johngmyers Oct 10, 2023

upodroid Oct 10, 2023

johngmyers Oct 10, 2023

upodroid Oct 10, 2023

hakman commented Oct 10, 2023

upodroid commented Oct 10, 2023

k8s-ci-robot commented Oct 12, 2023

k8s-ci-robot commented Jan 18, 2024

k8s-triage-robot commented Apr 17, 2024

k8s-triage-robot commented May 17, 2024

k8s-triage-robot commented Jun 16, 2024

k8s-ci-robot commented Jun 16, 2024

Configure ginkgo to use the KUBE_BASTION_SSH env variable #16008

Configure ginkgo to use the KUBE_BASTION_SSH env variable #16008

Conversation

upodroid commented Oct 8, 2023 • edited Loading

k8s-ci-robot commented Oct 8, 2023

upodroid commented Oct 10, 2023

johngmyers Oct 10, 2023

Choose a reason for hiding this comment

upodroid Oct 10, 2023

Choose a reason for hiding this comment

johngmyers Oct 10, 2023

Choose a reason for hiding this comment

upodroid Oct 10, 2023

Choose a reason for hiding this comment

hakman commented Oct 10, 2023

upodroid commented Oct 10, 2023

k8s-ci-robot commented Oct 12, 2023

k8s-ci-robot commented Jan 18, 2024

k8s-triage-robot commented Apr 17, 2024

k8s-triage-robot commented May 17, 2024

k8s-triage-robot commented Jun 16, 2024

k8s-ci-robot commented Jun 16, 2024

Configure ginkgo to use the `KUBE_BASTION_SSH` env variable #16008

Configure ginkgo to use the `KUBE_BASTION_SSH` env variable #16008

upodroid commented Oct 8, 2023 •

edited

Loading